[mypyc] feat: new primitive for weakref.ref.__call__
#19145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
force-pushed
the
weakref-call
branch
from
d535f84 to
3b71a7f
Compare
BobTheBuidler
changed the title
weakref.ref.__call__
BobTheBuidler
force-pushed
the
weakref-call
branch
from
f5c4cc8 to
e6e4a6b
Compare
ilevkivskyi
pushed a commit
that referenced
this pull request
Jul 31, 2025
This PR adds a new mypyc primitive for `weakref.ref` I wasn't able to figure out what name mypyc expects for `weakref.proxy`, so I took that out and will keep that for a separate PR later on. ref is more commonly used than proxy anyway. for later, I tried: - weakref.proxy - weakref.ProxyType - weakref.weakproxy no luck with those also for later, I'll need to finish #19145 to add a primitive for `weakref.ref.__call__`
BobTheBuidler
force-pushed
the
weakref-call
branch
from
e6e4a6b to
49d9cc0
Compare
BobTheBuidler
commented
Aug 2, 2025
BobTheBuidler
commented
Aug 2, 2025
| #endif | ||
|
|
||
|
|
||
| PyObject *CPyWeakref_GetRef(PyObject *ref) |
There was a problem hiding this comment.
We need a new C function because of the variability of PyWeakref_GetRef
for more information, see https://pre-commit.ci
BobTheBuidler
force-pushed
the
weakref-call
branch
from
d219f8f to
47ab0d4
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…into weakref-call
for more information, see https://pre-commit.ci
|
Is this still WIP? |
|
Ah no, this one is ready for review. Though I wouldn't call it "complete" quite yet. One open question, I'll add a comment in the code |
BobTheBuidler
commented
Aug 18, 2025
| builder: IRBuilder, expr: CallExpr, callee: RefExpr | ||
| ) -> Value | None: | ||
| """Invoke the Specializer callback for a function if one has been registered""" | ||
| if is_weakref_rprimitive(builder.node_type(callee)) and len(expr.args) == 0: |
There was a problem hiding this comment.
I think there's gotta be a better place for this, but I wasn't able to figure out how to make function_op or method_op work with the __call__ method
There was a problem hiding this comment.
@JukkaL There's also one open question here blocking me, and then I can finish this up
edit: hmm. Well it was working, some recent change on master appears to have broken this one. So I guess we have 2 open questions as I don't particularly understand any of the casting code.
for more information, see https://pre-commit.ci
BobTheBuidler
changed the title
weakref.ref.__call__weakref.ref.__call__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #19099, adding a new rprimitive type for
weakref.ReferenceTypeand another new custom_op primitive forweakref.ReferenceType.__call__to dereference reference objects.